HBASE-29598 Fix regionDir in clone snapshots wfw to clone all mob files rightly t…

[gvprathyusha6]

…o mobdir

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 47s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	4m 3s		master passed
+1 💚	compile	4m 5s		master passed
-0 ⚠️	checkstyle	0m 10s	/buildtool-branch-checkstyle-hbase-server.txt	The patch fails to run checkstyle in hbase-server
+1 💚	spotbugs	1m 53s		master passed
+1 💚	spotless	0m 56s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	4m 11s		the patch passed
+1 💚	compile	4m 3s		the patch passed
+1 💚	javac	4m 3s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 10s	/buildtool-patch-checkstyle-hbase-server.txt	The patch fails to run checkstyle in hbase-server
+1 💚	spotbugs	1m 59s		the patch passed
+1 💚	hadoopcheck	16m 25s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 59s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 15s		The patch does not generate ASF License warnings.
		51m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7309/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7309
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux c808c2562e1a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 8f9187a
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7309/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 38s		Docker mode activated.
-0 ⚠️	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	4m 11s		master passed
+1 💚	compile	1m 27s		master passed
+1 💚	javadoc	0m 37s		master passed
+1 💚	shadedjars	7m 18s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 59s		the patch passed
+1 💚	compile	1m 10s		the patch passed
+1 💚	javac	1m 10s		the patch passed
+1 💚	javadoc	0m 39s		the patch passed
+1 💚	shadedjars	6m 58s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	215m 13s		hbase-server in the patch passed.
		247m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7309/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7309
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 7b3885d3c1d6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 8f9187a
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7309/2/testReport/
Max. process+thread count	4048 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7309/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Copilot]

Pull Request Overview

This PR fixes an issue with clone snapshots where MOB (Medium Object) files were not being cloned correctly to the mob directory. The fix addresses the regionDir parameter used in the cloning process and ensures MOB regions use the default store file tracker.

• Fixed regionDir reference in RestoreSnapshotHelper to use the correct directory path for filesystem operations
• Added special handling for MOB regions to use the default store file tracker instead of the configured one

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
RestoreSnapshotHelper.java	Corrected regionDir parameter to fix MOB file cloning during snapshot restore
StoreFileTrackerFactory.java	Added MOB region detection and default tracker assignment for MOB operations

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

[nitpick] The nested method calls and multi-line condition check is hard to read. Consider extracting this MOB region check into a separate method like isMobRegion(StoreContext ctx) to improve readability and maintainability.

[Copilot]

Potential NullPointerException if ctx.getRegionInfo() or ctx.getTableName() returns null. Add null checks for these nested method calls or ensure they cannot be null in this context.

Suggested change

	ctx != null && ctx.getRegionInfo().getEncodedName()
	.equals(MobUtils.getMobRegionInfo(ctx.getTableName()).getEncodedName())
	ctx != null
	&& ctx.getRegionInfo() != null
	&& ctx.getTableName() != null
	&& ctx.getRegionInfo().getEncodedName()
	.equals(MobUtils.getMobRegionInfo(ctx.getTableName()).getEncodedName())