HBASE-29594: Add suffix to Master Region data directory #7330
+49
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
kgeisz
approved these changes
Sep 24, 2025
| Path rootDir = CommonFSUtils.getRootDir(conf); | ||
|
|
||
| assertTrue("Master region directory should use the suffix", | ||
| fs.exists(new Path(rootDir, "MasterData_replica1"))); |
There was a problem hiding this comment.
nit
Suggested change
| fs.exists(new Path(rootDir, "MasterData_replica1"))); | |
| fs.exists(new Path(rootDir, MasterRegionFactory.MASTER_STORE_DIR + "_replica1"))); |
There was a problem hiding this comment.
I don't think this is needed. Tests are good to have hardcoded values in order to detect anomalies in the code which happened after the test was introduced.
| assertTrue("Master region directory should use the suffix", | ||
| fs.exists(new Path(rootDir, "MasterData_replica1"))); | ||
| assertFalse("Default master region directory should not exist when suffix is used", | ||
| fs.exists(new Path(rootDir, "MasterData"))); |
There was a problem hiding this comment.
nit
Suggested change
| fs.exists(new Path(rootDir, "MasterData"))); | |
| fs.exists(new Path(rootDir, MasterRegionFactory.MASTER_STORE_DIR))); |
anmolnar
requested changes
Sep 29, 2025
| public static final String USE_HSYNC_KEY = "hbase.master.store.region.wal.hsync"; | ||
|
|
||
| // Default master data dir | ||
| public static final String MASTER_STORE_DIR = "MasterData"; |
There was a problem hiding this comment.
Can we make this private to make sure nobody is using it outside of this class?
| private void addAllHFiles() throws IOException { | ||
| Path masterProcDir = | ||
| new Path(CommonFSUtils.getRootDir(conf), MasterRegionFactory.MASTER_STORE_DIR); | ||
| new Path(CommonFSUtils.getRootDir(conf), MasterRegionFactory.getMasterRegionDirName(conf)); |
There was a problem hiding this comment.
Instead of calling the setter from here, add a new read-only property which will return the correct region dir name. Essentially making the property immutable.
| Path rootDir = CommonFSUtils.getRootDir(conf); | ||
|
|
||
| assertTrue("Master region directory should use the suffix", | ||
| fs.exists(new Path(rootDir, "MasterData_replica1"))); |
There was a problem hiding this comment.
I don't think this is needed. Tests are good to have hardcoded values in order to detect anomalies in the code which happened after the test was introduced.
| assertTrue("Master region directory should use the suffix", | ||
| fs.exists(new Path(rootDir, "MasterData_replica1"))); | ||
| assertFalse("Default master region directory should not exist when suffix is used", | ||
| fs.exists(new Path(rootDir, "MasterData"))); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: Add suffix to Master Region data directory