HBASE-29622 : Flaky Test in TestBackupDelete #7364
Open
+27
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchevreuil
reviewed
Oct 7, 2025
|
|
||
| private final ByteBuffAllocator byteBuffAllocator; | ||
|
|
||
|
|
There was a problem hiding this comment.
nit: remove unnecessary change.
There was a problem hiding this comment.
My bad, I think this was added by spotless:apply.
| incrTableSet.retainAll(tableMap.keySet()); | ||
|
|
||
| table.deleteIncrementalBackupTableSet(backupRoot); | ||
| busySpin(5); |
There was a problem hiding this comment.
Could we do with a simple wait() instead?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…crementalBackupSet
dev-work-8103
force-pushed
the
HBASE-29622
branch
from
ed431a7 to
26fe40d
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testBackupDeleteUpdatesIncrementalBackupSet is flaky.
BackupAdminImpl.finalizeDelete() method first deletes Incremental table set in BackupSystemTable and then updates it with new Incremental table set. In this process race condition is occuring between Delete and Put calls.
In a very rare scenario, These Delete and Put Objects are having same timestamps and because of that We're encountering Lost Update error. Because of this Result of Get call is empty for same row key and We're having assertion failure.