-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29531 Migrate RegionServer Status Jamon page back to JSP #7371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Also fix content-type of master JSON task view.
Also share formatZKString method with Master Status page.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
to satisfy checkstyle.
to fix rubocop violation about the lines being too long.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I tested this locally in standalone mode after building with Maven ( ![]() Also configured BlockCache accordiong to the example configuration https://hbase.apache.org/book.html#bc.example
and checked the RS status page if the Block Cache details and the Hit ration periods are properly displayed: ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in first.
hbase-server/src/main/java/org/apache/hadoop/hbase/util/ZKUtil.java
Outdated
Show resolved
Hide resolved
We already had another ZKUtil.
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
ℹ️ Sorry, this PR is also quite large and I did not found a way to make it smaller. Maybe it is better to check the changes commit-by-commit.
This is the 2/3 step of the Jamon to JSP migration: the Region Server Status page.
Did the migration the same way as for the Master Status page: #6875
Migrated the Jamon code to JSP as close as possible. Extracted the duplicated
formatZKString
method to new java class: ZKUtil and added unit tests.Changed the Region Server Status page back to
/regionserver.jsp
. Made sure that/rs-status
redirects to/regionserver.jsp
.Extracted the BlockCache inline CSS styles to
hbase.css
file. Also extracted the large BlockCache Hit Ratio periods paging JavaScript code to separate .js file.Introduced a
src/main/resources/hbase-webapps/common
directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit.Extracted the inline tablesorter initialization JavaScript code to separate file.