fixed:a minor issue change #3428
Open
+27
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to address issues with JDBC URL sanitization by improving URL decoding and adding extra validation for H2 JDBC URLs.
- Adds URL decoding and handles decoding errors gracefully.
- Enhances H2 URL verification with additional regex checks for malicious parameters.
| if (!url.matches("^jdbc:[a-zA-Z0-9]+://[^\\s]+$")) { | ||
| throw new IllegalArgumentException("Invalid JDBC URL format"); | ||
| // url format check - potentially adjust regex based on H2 specifics if needed | ||
| if (jdbcProtocol.getPlatform() != null && jdbcProtocol.getPlatform().equalsIgnoreCase("h2")) { |
There was a problem hiding this comment.
The modifications to the H2 URL (stored in the variable h2Url) are never propagated back to the returned URL. Consider reassigning cleanedUrl to the processed h2Url after the H2-specific checks to ensure the normalization is effective.
Copilot uses AI. Check for mistakes.
github-project-automation
bot
added this to
hertzbeat-v1.0 and Apache HertzBeat (Incubating)
tomsun28
reviewed
Jun 6, 2025
Comment on lines
+373
to
+379
| // url format check - potentially adjust regex based on H2 specifics if needed | ||
| if (jdbcProtocol.getPlatform() != null && jdbcProtocol.getPlatform().equalsIgnoreCase("h2")) { | ||
| String h2Url = url; | ||
| // Uniformly handle invisible characters (e.g., \u00A0), replacing them with spaces | ||
| h2Url = h2Url.replaceAll("[\\x00-\\x1F\\x7F\\xA0]", " "); | ||
| // Convert to lowercase | ||
| h2Url = h2Url.toLowerCase(); |
There was a problem hiding this comment.
Is it possible that other JDBC drivers, not just H2, could have this issue as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a small problem.