[bugfix] Fix incorrect expression parsing in alert setting component #3497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
added this to
Apache HertzBeat (Incubating) and hertzbeat-v1.0
MasamiYui
reviewed
Jun 24, 2025
github-project-automation
bot
moved this from To do
to Done
in Apache HertzBeat (Incubating)
lx1229
pushed a commit
to lx1229/hertzbeat
that referenced
this pull request
Jun 26, 2025
…pache#3497) Co-authored-by: Calvin <[email protected]> Co-authored-by: tomsun28 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
#3494
This PR resolves a critical parsing error within the alert settings component. The error occurred when editing an existing threshold rule with
contains(__labels__,"xxx"), causing the expression to be displayed incorrectly and making the rule uneditable.The underlying issue was that the logic for extracting the user-facing expression (
user_expr) from the full, raw expression (raw_expr) did not properly filter out internal clauses likecontains(__label__,"xxx"). This resulted in a failed visualization of the metric expression.test:
label_bug_fix.mp4
Checklist
Add or update API