-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[feature] Support for Periodic Threshold
preview.
#3505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
looks great! |
hh, review it for me if you have time. 😉 |
...at-alerter/src/main/java/org/apache/hertzbeat/alert/service/impl/AlertDefineServiceImpl.java
Outdated
Show resolved
Hide resolved
I don't think there is anything to worry about for the following reasons.
|
@Duansg How about adding a marker to the corresponding row if it can trigger an alert? |
@MasamiYui Sorry, I didn't quite get your point, could you expand on it. :) |
@MasamiYui Emmm, this is indeed in line with the current design, but I think we should not add this description for the time being, for the following reasons
Therefore, I think that it is enough to achieve the effect of |
Sorry friends, I'm busy with work recently. I will continue to improve this PR tomorrow. If you are all free at that time, please review it for me. Thanks. 😅 |
I agree, see #3496 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What's changed?
Support for
Periodic Threshold
preview.For details:
Threshold
->Periodic Threshold
preview, exception content support for internationalizationLook Ahead
method to determine if parsing is finished.Checklist
Add or update API
1、andOp

2、compareOp

3、orOp
