Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-28584: Add the reader parameter when orcTail is initialized #5514

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zzzzming95
Copy link
Contributor

What changes were proposed in this pull request?

Add the reader parameter when orcTail is initialized

Why are the changes needed?

When we use Spark to read the Hive ORC table, we will encounter the following logs

Please use Reader.getStripeStatistics or give `Reader` to OrcTail constructor.

It looks like this causes the orc to not be able to push down . So add the reader para in hive .

Does this PR introduce any user-facing change?

no

Is the change a dependency upgrade?

no

How was this patch tested?

Manual testing

Copy link

sonarcloud bot commented Oct 20, 2024

@zhangbutao zhangbutao changed the title Add the reader parameter when orcTail is initialized HIVE-28584: Add the reader parameter when orcTail is initialized Oct 21, 2024
file.getModificationTime());
BufferChunk bufferChunk = new BufferChunk(orcReader.getSerializedFileFooter(),
getStripeStatisticsOffset(orcReader.getFileTail()));
orcTail = new OrcTail(orcReader.getFileTail(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the ORC change: https://github.com/apache/orc/pull/549/files#diff-379a4569d065dfbffdc854790e0de07329025e608e0fb0f5bc03b8a4b9d00f92
Can we use Reader.getStripeStatistics in Apache Spark instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants