HIVE-28593: INSERT OVERWRITE DIRECTORY is not cleaning up the HDFS data #5522
+27
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
difin
reviewed
Oct 29, 2024
Comment on lines
+157
to
+163
| public boolean getIsOverwrite() { | ||
| return isOverwrite; | ||
| } | ||
|
|
||
| public void setIsOverwrite(boolean isOverwrite) { | ||
| this.isOverwrite = isOverwrite; | ||
| } |
There was a problem hiding this comment.
It is better to name the getters/setters for boolean members like getOverwrite() and setOverwrite().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
INSERT OVERWRITE DIRECTORY will clean up the hdfs directory when zero rows are available to insert.
Why are the changes needed?
HDFS directory is not cleaned up and it can lead to data correctness issues.
Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
No.
How was this patch tested?
Manual testing