HIVE-28824: Metastore should also respect the max thrift message size #5699
+163
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests unstable
tests failed
tests passed
and removed
tests pending
tests unstable
tests failed
labels
deniskuzZ
reviewed
Mar 19, 2025
itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestJdbcWithMiniKdc.java
Show resolved
Hide resolved
deniskuzZ
reviewed
Mar 19, 2025
service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java
Show resolved
Hide resolved
deniskuzZ
reviewed
Mar 19, 2025
.../metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreTServerSocket.java
Outdated
Show resolved
Hide resolved
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
tests unstable
labels
deniskuzZ
reviewed
Mar 20, 2025
.../metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreTServerSocket.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Mar 20, 2025
.../metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreTServerSocket.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Mar 21, 2025
...metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
Show resolved
Hide resolved
asf-ci-hive
added
tests unstable
tests pending
tests failed
and removed
tests pending
tests unstable
tests failed
labels
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
tests unstable
labels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Respect the max thrift message on the server side
Why are the changes needed?
By default the Thrift allows the payload of message 100M at most, if current call exceeds this limit, the server will kill the connection silently, and the client will receive the exception indicating the connection is closed.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
UT