HIVE-28904: Remove Arrow from Hive #5772
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
abstractdog
changed the title
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
okumin
approved these changes
Apr 20, 2025
| @@ -219,26 +191,8 @@ public RecordReader<NullWritable, V> getRecordReader(InputSplit split, JobConf j | |||
|
|
|||
| LOG.info("Registered id: " + fragmentId); | |||
|
|
|||
| @SuppressWarnings("rawtypes") | |||
There was a problem hiding this comment.
I guess this warning would disappear if we restored this annotation.
https://sonarcloud.io/project/issues?sinceLeakPeriod=true&issueStatuses=OPEN%2CCONFIRMED&pullRequest=5772&id=apache_hive&open=AZY1rqPeKcDofJK_Opr6
| @@ -198,16 +198,9 @@ private void registerReader(ChannelHandlerContext ctx, String id, byte[] tokenBy | |||
| LOG.debug("registering socket for: " + id); | |||
| int maxPendingWrites = HiveConf.getIntVar(conf, | |||
| HiveConf.ConfVars.LLAP_DAEMON_OUTPUT_SERVICE_MAX_PENDING_WRITES); | |||
| boolean useArrow = HiveConf.getBoolVar(conf, HiveConf.ConfVars.LLAP_OUTPUT_FORMAT_ARROW); | |||
| @SuppressWarnings("rawtypes") | |||
|
|
thanks @okumin for the review! |
okumin
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To remove Arrow dependency and usage from hive.
Why are the changes needed?
Maintenance burden, and it's not used anymore.
https://lists.apache.org/thread/j1hclgwqytbhdbbbw12sy1nrpxvbq1c1
Does this PR introduce any user-facing change?
No, unless the user still utilizes a long-time abandoned hive warehouse connector reader mode.
Is the change a dependency upgrade?
No.
How was this patch tested?
Precommit testing.