Skip to content

Conversation

KiranVelumuri
Copy link
Contributor

What changes were proposed in this pull request?

Disable HBase web UI while setting up MiniHBaseCluster for HBase tests.

Why are the changes needed?

Improvement

Does this PR introduce any user-facing change?

No

How was this patch tested?

mvn test -Dtest=TestHBaseQueries
mvn test -Dtest=TestHBaseCliDriver
mvn test -Dtest=TestHBaseNegativeCliDriver

Copy link

sonarqubecloud bot commented Sep 1, 2025

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like how much do we save here? these are basic integration tests in HBase. it has default values which enables bunch of things which we don't need, but still ok.

I believe that would be the case with Hadoop services as well. I am curious like how much is the improvement

@KiranVelumuri
Copy link
Contributor Author

Taking reference from ManyMiniCluster, I used it here for HBase tests. This is good to have when we upgrade javax.servlet.X classes and could help avoid loading of such classes in HBase tests.

There has been no improvement in test times as seen below.

Test Avg. runtime (in sec) Avg. runtime (in sec)
Before After
TestHBaseQueries 48.353 44.529
TestHBaseCliDriver 758.333 762.667
TestHBaseNegativeCliDriver 59.440 58.109

@ayushtkn
Copy link
Member

ayushtkn commented Sep 3, 2025

thanx for the details. I don't feel the need for this, but I won't come in the way. If others feel it is good, I won't be blocking this

@KiranVelumuri
Copy link
Contributor Author

@ayushtkn Got it. Thank you for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants