HIVE-29191: Gracefully Handle Removed Configuration Properties in Hiv… #6073
+58
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e 4 to Avoid Job Failures
|
zabetak
reviewed
Sep 11, 2025
Comment on lines
+5610
to
+5613
| HIVE_IGNORE_REMOVED_CONFIGS_LIST("hive.ignore.removed.configs.list", | ||
| "", | ||
| "Comma separated list of configuration options which are removed from hive code. Silently ignore if the user tries to set them"), | ||
|
|
There was a problem hiding this comment.
I don't think we need a new property since this complicates the deprecation and removal of properties even more. hive.conf.validation seems to be enough for skipping validation although I don't like much this flag either.
Comment on lines
+7269
to
+7272
| public static String generateRemovedWarning() { | ||
| return "This config does not exist in the current version of Hive. Consider removing this config."; | ||
| } | ||
|
|
There was a problem hiding this comment.
There are better ways to log warning about deprecated/removed properties. See: org.apache.hadoop.conf.Configuration#addDeprecation
| Sets.newHashSet("hive.mapred.supports.subdirectories", | ||
| "hive.enforce.sorting","hive.enforce.bucketing", | ||
| "hive.outerjoin.supports.filters", | ||
| "hive.llap.zk.sm.principal", | ||
| "hive.llap.zk.sm.keytab.file" | ||
| "hive.llap.zk.sm.keytab.file", | ||
| "hive.stats.fetch.partition.stats", |
There was a problem hiding this comment.
there are other configs as well which I found doesn't exist in hive:
- hive.repl.dumpdir.ttl
- hive.repl.dumpdir.clean.freq
- hive.llap.io.vrb.queue.limit.base
- hive.llap.external.splits.order.by.force.single.split
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e 4 to Avoid Job Failures
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?