Skip to content

HTTPCORE-766: redesign of server-side request routing #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

ok2c
Copy link
Member

@ok2c ok2c commented Jun 1, 2024

Redesign of server-side request routing:

  • support for multiple authorities (defined as hostname / port pair)
  • customizable authority resolution / authority normalization
  • support for router chaining

@erik-wramner
Copy link

Overall this looks fine, though it was a much larger change than I had anticipated. I only have one question. The code uses UriPatternType.URI_PATTERN and the other types have been deprecated. I don't quite follow the reasoning there? It won't affect our code, but I don't get why that was changed.

@ok2c
Copy link
Member Author

ok2c commented Jun 2, 2024

Overall this looks fine, though it was a much larger change than I had anticipated.

@erik-wramner True. I ended up rewriting the entire request routing layer as a result.

I only have one question. The code uses UriPatternType.URI_PATTERN and the other types have been deprecated. I don't quite follow the reasoning there? It won't affect our code, but I don't get why that was changed.

That is not the case. All existing UriPatternType are not deprecated but their matcher implementations have been made internal. They should have never been made public in the first place.

@ok2c ok2c merged commit 9292718 into apache:master Jun 5, 2024
10 checks passed
@ok2c ok2c deleted the HTTPCORE-766 branch June 5, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants