fix: chore cargo lock and fix two warning for python bindings #1121
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yihong0618 <[email protected]>
kevinjqliu
approved these changes
Mar 21, 2025
There was a problem hiding this comment.
LGTM
I see
warning: use of deprecated associated function `pyo3::types::PyModule::new_bound`: renamed to `PyModule::new`
in an action run on main branch without this change, https://github.com/apache/iceberg-rust/actions/runs/13987670489/job/39164414042
But no such warning in the action run for this PR, https://github.com/apache/iceberg-rust/actions/runs/13992145482/job/39178304868?pr=1121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This patch chore the cargo.lock and fix the warning for python binding