Skip to content

Rename pyiceberg_core to pyiceberg-core #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Rename pyiceberg_core to pyiceberg-core #1134

merged 1 commit into from
Mar 24, 2025

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Mar 24, 2025

What changes are included in this PR?

When I go to:

https://pypi.org/project/pyiceberg_core/

It redirects to:

https://pypi.org/project/pyiceberg-core/

We also install pyiceberg-core in PyIceberg, so I think pypi automatically replaces the underscore with a dash.

Are these changes tested?

When I go to:

https://pypi.org/project/pyiceberg_core/

It redirects to:

https://pypi.org/project/pyiceberg-core/

We also install `pyiceberg-core` in PyIceberg, so I think
pypi automatically replaces the underscore with a dash.
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@Xuanwo Xuanwo merged commit 658be98 into apache:main Mar 24, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants