feat: add an AddFieldsAction to transaction #1176
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
AddFields
operation #1174.What changes are included in this PR?
AddFieldsAction
which represents an addition of new fields to an existing tableadd_fields
which generates anAddFieldsAction
AddFieldsAction
will register a new schema with the addition of the new fields, and set the current schema version to (schema + 1). (I am not highly confident that this is the right way to manage the schema id, though I've verified that it works in my testing. Is there a better way to mark the next schema version as the current one? Is this necessary?)Are these changes tested?
Added tests:
Unit: in crates/iceberg/src/transaction/add_field.rs
Integration: in crates/integration_tests/tests/shared_tests/add_field_test.rs