feat(datafusion): Add TaskWriter for DataFusion #1769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTTY
commented
Oct 20, 2025
CTTY
commented
Oct 20, 2025
CTTY
commented
Oct 21, 2025
CTTY
commented
Oct 21, 2025
CTTY
commented
Oct 21, 2025
CTTY
force-pushed
the
ctty/task-writer
branch
from
e875e8e to
f4b72ef
Compare
Comment on lines
85
to
87
| Fanout(FanoutWriter<B>), | ||
| /// Writer for partitioned tables with sorted data (maintains single active writer) | ||
| Clustered(ClusteredWriter<B>), |
There was a problem hiding this comment.
We could simplify this as
Partitioned {
splitter: RecordBatchSplitter,
partitioned_writer: Arc<dyn PartitionedWriter>
}
liurenjie1024
pushed a commit
that referenced
this pull request
Oct 28, 2025
…atchPartitionSplitter (#1781) ## Which issue does this PR close? - Closes #1786 - Covered some of changes from the previous draft: #1769 ## What changes are included in this PR? - Move PartitionValueCalculator to core/arrow so it can be reused by RecordBatchPartitionSplitter - Allow skipping partition value calculation in partition splitter for projected batches - Return <PartitionKey, RecordBatch> rather than <Struct, RecordBatch> pairs in RecordBatchPartitionSplitter::split ## Are these changes tested? Added uts
CTTY
force-pushed
the
ctty/task-writer
branch
from
c5061e2 to
d3d3127
Compare
CTTY
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
RecordBatchPartitionSplitterand projected partition valuesAre these changes tested?
Added unit tests