Skip to content

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Oct 28, 2025

Which issue does this PR close?

  • Closes #.

What changes are included in this PR?

This PR is going to relax the MSRV check thanks to rust 2024. Since starts from rust 2024, cargo has msrv aware dep resolve. This means that dep's upgrade no a problem now.

Are these changes tested?

@mbutrovich
Copy link
Contributor

Would that mean we could undo these two recent commits?
#1783
#1785
If I have time I will try to test this branch with those two commits removed.

@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 28, 2025

Would that mean we could undo these two recent commits? #1783 #1785 If I have time I will try to test this branch with those two commits removed.

Yep, technically we don't need to play the cargo.toml and cargo.lock game anymore.

Copy link
Contributor

@mbutrovich mbutrovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out this branch (git fetch upstream pull/1795/head:pr-1795-msrv-check && git checkout pr-1795-msrv-check), did a revert on #1783 and #1785 (git revert 104a0167 ddbcae46 --no-edit), and did an MSRV check (make check-msrv) and everything passed. LGTM! Thank you @Xuanwo!

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Xuanwo for this fix!

@liurenjie1024 liurenjie1024 merged commit 3cb18e7 into main Oct 29, 2025
27 of 28 checks passed
@liurenjie1024 liurenjie1024 deleted the polish-msrv branch October 29, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants