Skip to content

Conversation

@mbutrovich
Copy link
Contributor

@mbutrovich mbutrovich commented Oct 30, 2025

Which issue does this PR close?

    /// This reproduces the scenario from Iceberg Java's TestAddFilesProcedure where:
    /// - Date partition columns have initial_default values in manifests
    /// - These values are serialized as days since epoch (e.g., 18628 for 2021-01-01)
    /// - The JSON schema includes: {"type":"date","initial-default":18628}

What changes are included in this PR?

Add a match arm for deserializing a Date32 from days since the epoch.

Are these changes tested?

@mbutrovich mbutrovich changed the title date32 from number not just string date feat(reader): Date32 from days since epoch for Literal:try_from_json Oct 30, 2025
);

// Both formats should produce the same Literal value
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is already 4000 lines long 🤯 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants