Conversation
Merged
6d0a7ee to
56f068e
Compare
Contributor
Author
|
@Xuanwo and @liurenjie1024: This is now passing and ready for review. |
f90d2d4 to
a00b32a
Compare
Xuanwo
reviewed
Aug 16, 2024
Member
Xuanwo
left a comment
There was a problem hiding this comment.
Thanks a lot for driving this work!
This was referenced Aug 16, 2024
Contributor
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @sdd for this pr. I just skimmed through it and got your points here. I have some concerns with this approach, for example, I feel this approach is difficult to maintain and extend to other cases. I'm more interested in integrated with datafusion to do such thing, like integration tests and benchmark. What do you think?
…n measuring performance of row group filtering and row selection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some performance testing capabilities. It includes the following features:
TableScan.plan_filesin four different representative scenariosTableScan.to_arrowin four different representative scenariosThe performance tests can be set up and ran by running
just perf-run. This will trigger the following actions before actually running the tests. It checks each item to see if it actually needs to be run, skipping if already done on a previous run: