Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Check referencedDataFile existence for DV #12088

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Conversation

ebyhr
Copy link
Contributor

@ebyhr ebyhr commented Jan 24, 2025

This field is required for DV. I missed setting this field when preparing deletion vector's changes in Trino, and it resulted in incorrect results even though DELETE statement succeeded. It would be nice to fail early.

/**
* Returns the location of a data file that all deletes reference.
*
* <p>The referenced data file is required for deletion vectors and may be optionally captured for
* position delete files that apply to only one data file. This method always returns null for
* equality delete files.
*/
default String referencedDataFile() {
return null;
}

@github-actions github-actions bot added the core label Jan 24, 2025
@nastra nastra merged commit 491d906 into apache:main Jan 28, 2025
46 checks passed
@ebyhr ebyhr deleted the ebi/dv-check branch February 1, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants