Spark: Custom snapshot property from session configuration #14545
+60
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhpk234
reviewed
Nov 10, 2025
| @@ -396,6 +396,37 @@ public void testSparkConfOverride() { | |||
| } | |||
| } | |||
|
|
|||
| @TestTemplate | |||
| public void testExtraSnapshotMetadataReflectsSessionConfig() { | |||
Contributor
There was a problem hiding this comment.
can we add a E2E test which verifies that when this is set the snapshot created actually persists the given property as snapshot property ?
Author
There was a problem hiding this comment.
Thanks for the comment (and sorry for the late reply). Added a E2E test testExtraSnapshotMetadataPersistedOnWrite for this purpose.
huaxingao
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on this PR and move it to Spark 4.0.
Adds support to allow custom snapshot properties to be specified in the Spark session configuration. This allows users to add custom snapshot properties even when running spark SQL DML such as DELETE or MERGE INTO, which was not previously supported.