-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Build: Upgrade Gradle to 9.2.0 #14560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @jbonofre, here are my changes, if you want to use anything from it. Please let me know if you have any questions or need any help: happy to chat. Thanks! |
jbonofre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first glance, the change is good. However, I have two comments:
- Did you check a release is still valid ? I see a change in the generated artifacts.
- As I said in the GitHub Issue, Gradle 9.x requires JDK17+. AFAIR, not all parts of Iceberg are ready to JDK17+ AFAIR. We have to double check and verify with the community here.
| classpath 'com.gradleup.shadow:shadow-gradle-plugin:8.3.9' | ||
| classpath 'com.palantir.baseline:gradle-baseline-java:5.72.0' | ||
| classpath 'com.diffplug.spotless:spotless-plugin-gradle:6.25.0' | ||
| classpath 'gradle.plugin.org.inferred:gradle-processors:3.7.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I would add just a note to explain why processors plugin can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
build.gradle
Outdated
| testImplementation project(':iceberg-api') | ||
| testImplementation project(':iceberg-core') | ||
| testImplementation project(':iceberg-core').sourceSets.test.runtimeClasspath | ||
| testImplementation project(path: ':iceberg-api', configuration: 'testArtifacts') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think iceberg-api is required here (`iceberg-core should be enough).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing
testImplementation project(path: ':iceberg-api', configuration: 'testArtifacts') causes following failures -
> Task :iceberg-open-api:test
RESTCompatibilityKitCatalogTests > testRegisterTable() FAILED
java.lang.NoClassDefFoundError: org/apache/iceberg/TestHelpers
at org.apache.iceberg.catalog.CatalogTests.testRegisterTable(CatalogTests.java:3139)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by:
java.lang.ClassNotFoundException: org.apache.iceberg.TestHelpers
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:642)
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
... 4 more
Iceberg REST Compatibility Kit > JUnit Jupiter > RESTCompatibilityKitCatalogTests > testRegisterTable() FAILED
java.lang.NoClassDefFoundError: org/apache/iceberg/TestHelpers
at org.apache.iceberg.catalog.CatalogTests.testRegisterTable(CatalogTests.java:3139)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by:
java.lang.ClassNotFoundException: org.apache.iceberg.TestHelpers
at org.apache.iceberg.catalog.CatalogTests.testRegisterTable(CatalogTests.java:3139)
... 3 more
| } | ||
|
|
||
| artifacts { | ||
| archives sourceJar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have to keep sourceJar, javadocJar, and testJar here as it's required to have a valid release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restored
Hi @jbonofre , for #2 above, I'd appreciate if you can please lead the discussion, and please add me. I am brand new to the repo, and happy to do the work and learn. Thanks! |
|
@nbdevos25 sure. I will help. Let me do a complete pass. Thanks. |
a75a996 to
7e663c0
Compare
#14094
java -version