OpenAPI: Add storage-credentials to CompletedPlanningResult #14563
Conversation
| status: | ||
| $ref: '#/components/schemas/PlanStatus' | ||
| const: "completed" | ||
| storage-credentials: |
There was a problem hiding this comment.
I wonder if we should have description here stating these creds are subscoped to scan or something, thoughts ?
There was a problem hiding this comment.
I'm not sure the spec should dictate or be opinionated that the creds are specifically subscoped, just that the client should be able to use these creds to access files returned in the scan result, but if others feel strongly, I'm not totally opposed.
There was a problem hiding this comment.
I agree that we shouldn't have wording in the spec saying that the creds are subscoped. It is up to the server to subscope those or not
There was a problem hiding this comment.
my understanding if the creds are present in the scan response we should not use the creds that were vended in loadTable ? hence some literature around of these cred should be the one used when server returns it irrespective of what was vended from the loadTable ?
There was a problem hiding this comment.
I added a description, let me know if that works or it needs re-wording
| """ | ||
|
|
||
| status: Literal['completed'] = Field(..., const=True) | ||
| storage_credentials: Optional[List[StorageCredential]] = Field( |
There was a problem hiding this comment.
I put these as optional, anyone have thoughts or opinions if these should be required?
3 participants
Adding to the spec a way to pass the client credentials specific to the Scan Plan results. Both the
planTableScanandfetchPlanningResultreturn a CompletedPlanningResult when scan plan is completed.ML discussion: https://lists.apache.org/thread/ko9kp0gvzhx85n7cvoxqnpw4vwnhmdg6