Encryption clean up #14579
Open
Encryption clean up #14579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @huaxingao |
huaxingao
reviewed
Nov 16, 2025
| @Deprecated | ||
| public AesGcmInputFile(InputFile sourceFile, byte[] dataKey, byte[] fileAADPrefix) { | ||
| this(sourceFile, dataKey, fileAADPrefix, null); | ||
| throw new IllegalArgumentException("Can't create AesGcmInputFile without file length"); |
Contributor
There was a problem hiding this comment.
This introduces a breaking change. Can we change to:
this(sourceFile, dataKey, fileAADPrefix, sourceFile.getLength();
and move
throw new IllegalArgumentException("Can't create AesGcmInputFile without file length");
to
public AesGcmInputFile(InputFile sourceFile, byte[] dataKey, byte[] fileAADPrefix, Long length)
?
huaxingao
reviewed
Nov 16, 2025
| @Override | ||
| public InputFile toInputFile() { | ||
| return new AesGcmInputFile(targetFile.toInputFile(), dataKey, fileAADPrefix); | ||
| throw new IllegalStateException("File length unknown, creating an AesGcmInputFile is not safe"); |
Contributor
There was a problem hiding this comment.
This introduces a breaking change. Can we keep the current behavior but deprecate it in 2.0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.