API, Core: Align offsets of field stats with Design doc / Spec#15432
Open
nastra wants to merge 1 commit intoapache:mainfrom
Open
API, Core: Align offsets of field stats with Design doc / Spec#15432nastra wants to merge 1 commit intoapache:mainfrom
nastra wants to merge 1 commit intoapache:mainfrom
Conversation
nastra
commented
Feb 24, 2026
| } | ||
|
|
||
| public static Types.StructType fieldStatsFor(Type type, int fieldId) { | ||
| public static Types.StructType fieldStatsFor(Type type, int baseFieldId) { |
Contributor
Author
There was a problem hiding this comment.
we used to always pass baseFieldId + 1 here instead of just the baseFieldId
nastra
force-pushed
the
content-stats-update-offsets
branch
from
139be61 to
87bc9cf
Compare
Fokko
approved these changes
Feb 24, 2026
huaxingao
reviewed
Feb 25, 2026
| assertThatThrownBy(() -> assertThat(fieldStats.get(10, Long.class))) | ||
| .isInstanceOf(IllegalArgumentException.class) | ||
| .hasMessage("Invalid statistic offset: 10"); | ||
| .hasMessage("Invalid statistic position: 10"); |
Contributor
There was a problem hiding this comment.
in the line below, should it use VALUE_COUNT.offset() - 1?
stevenzwu
reviewed
Feb 25, 2026
| record.set(LOWER_BOUND.offset(), fieldStats.lowerBound()); | ||
| record.set(UPPER_BOUND.offset(), fieldStats.upperBound()); | ||
| record.set(EXACT_BOUNDS.offset(), fieldStats.hasExactBounds()); | ||
| record.set(VALUE_COUNT.offset() - 1, fieldStats.valueCount()); |
Contributor
There was a problem hiding this comment.
nit: we can probably introduce a position method in the enum definition. its implementation would just be offset() - 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns the offsets in the impl with the offets mentioned in the design doc and the Spec. The offsets are starting at 1 and are describing the offset of the field ID from the base stats structure, whereas the Java impl was using the offsets based on their position (0-based) within the stats structure.