refactor(configs): move ServerConfig types from server to configs crate#2796
Open
refactor(configs): move ServerConfig types from server to configs crate#2796
Conversation
709b5dc to
63671aa
Compare
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (34.60%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #2796 +/- ##
=========================================
Coverage 68.39% 68.40%
Complexity 656 656
=========================================
Files 852 853 +1
Lines 68185 68176 -9
Branches 59646 59647 +1
=========================================
- Hits 46636 46634 -2
+ Misses 19212 19198 -14
- Partials 2337 2344 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
7229f17 to
555b559
Compare
numinnex
previously approved these changes
Feb 25, 2026
Config types were coupled to the server binary, forcing dependents to pull in the entire server crate. Move them to core/configs/ with a thin re-export facade so existing server imports stay unchanged. Add TODO for extracting iggy_types leaf crate to break the configs <-> iggy_common cycle and eliminate the MemoryPoolConfigOther duplicate.
555b559 to
32a11c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config types were coupled to the server binary, forcing
dependents to pull in the entire server crate. Move them
to core/configs/ with a thin re-export facade so existing
server imports stay unchanged.
Add TODO for extracting iggy_types leaf crate to break
the configs <-> iggy_common cycle and eliminate the
MemoryPoolConfigOther duplicate.