IGNITE-23252 ItReplicaLifecycleTest is unstable #4956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAkutenshi
force-pushed
the
ignite-23252
branch
from
97b19d2 to
93f97ce
Compare
# Conflicts: # modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java # modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
# Conflicts: # modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItReplicaLifecycleTest.java
kgusakov
suggested changes
Jan 29, 2025
...va/org/apache/ignite/internal/partition/replicator/LocalPartitionReplicaEventParameters.java
Outdated
Show resolved
Hide resolved
sanpwc
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: IGNITE-23252
The goal
The goal of the PR is to enable
ItReplicaLifecycleTestclass. The tests shouldn't throw any assertion errors or be unstable.The reason
We're arising the colocation epic and want already written tests are work and stable.
The solution
The main change is to change
destroyPartitionStoragestoweakStopAndDestroyPartitionbecause then we could be ensured that table replica will be stopped before related RAFT storages will be removed.All further work related to wrong storage destruction on ignite node stopping process is related to IGNITE-23741