IGNITE-24022 Sql. Fix CreateSchemaCommand catalog command validation #5084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowka
reviewed
Jan 23, 2025
| @ParameterizedTest | ||
| @MethodSource("reservedSchemaNames") | ||
| public void testDropSystemSchemas(String schema) { | ||
| if (!DEFAULT_SCHEMA_NAME.equals(schema)) { |
There was a problem hiding this comment.
I think default schema name is PUBLIC and the PUBLIC schema is not on a list of reservedSchemaNames.
There was a problem hiding this comment.
you right, fixed, thanks
lowka
approved these changes
Jan 23, 2025
added 2 commits
January 30, 2025 09:35
| @@ -348,6 +347,44 @@ public void testItIsNotPossibleToCreateTablesInSystemSchema(String schema) { | |||
| () -> sql(format("CREATE TABLE {}.SYS_TABLE (NAME VARCHAR PRIMARY KEY, SIZE BIGINT)", schema.toLowerCase()))); | |||
| } | |||
|
|
|||
| @ParameterizedTest | |||
| @MethodSource("reservedSchemaNames") | |||
| public void testCreateSystemSchemas(String schema) { | |||
There was a problem hiding this comment.
can we make these tests as SqlLogic tests?
There was a problem hiding this comment.
But, as you correctly noted in such a case we will miss return code check
There was a problem hiding this comment.
it is so, but it doesn't look like a big problem. Otherwise, we can introduce check error codes in SqlLogic tests and move all such simple cases. Up to you
added 2 commits
January 30, 2025 11:38
|
@AMashenkov reworked, ready for review |
AMashenkov
reviewed
Jan 31, 2025
Comment on lines
68
to
70
| if (!systemSchemaCommand && CatalogUtils.isSystemSchema(schemaName)) { | ||
| throw new CatalogValidationException("Reserved system schema with name '{}' can't be created.", schemaName); | ||
| } |
There was a problem hiding this comment.
Let's move to the constructor.
AMashenkov
approved these changes
Jan 31, 2025
added 2 commits
February 3, 2025 09:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes