Skip to content

[GLUTEN-1433][VL]feat: Support TimestampNTZType for Velox #10153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

p1rattttt
Copy link

What changes were proposed in this pull request?

Support of TimestampNTZType

How was this patch tested?

I built gluten with patch and tested that tables with TIMESTAMP_NTZ columns are both readable and writable

@github-actions github-actions bot added CORE works for Gluten Core VELOX labels Jul 9, 2025
Copy link

github-actions bot commented Jul 9, 2025

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

github-actions bot commented Jul 9, 2025

Run Gluten Clickhouse CI on x86

@p1rattttt p1rattttt changed the title [VL] Support TimestampNTZType for Velox [GLUTEN-1433][VL] Support TimestampNTZType for Velox Jul 9, 2025
Copy link

github-actions bot commented Jul 9, 2025

#1433

@p1rattttt p1rattttt changed the title [GLUTEN-1433][VL] Support TimestampNTZType for Velox [GLUTEN-1433][VL]feat: Support TimestampNTZType for Velox Jul 9, 2025
Copy link

Run Gluten Clickhouse CI on x86

@FelixYBW
Copy link
Contributor

Is there Spark UT to cover TimestampNTZType? There are couple of timestamp UTs are excluded in Gluten now.

like:

.exclude("SPARK-35711: cast timestamp without time zone to timestamp with local time zone")
.exclude("SPARK-35719: cast timestamp with local time zone to timestamp without timezone")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE works for Gluten Core VELOX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants