[GLUTEN-10162] [build] fix: GCC build fix #10161
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
NN---
changed the title
|
Cc @zml1206 as he is also fixing macos builds |
zml1206
reviewed
Jul 11, 2025
| @@ -101,7 +101,7 @@ function compile { | |||
| # Maybe there is some set option in velox setup script. Run set command again. | |||
| set -exu | |||
|
|
|||
| CXX_FLAGS='-Wno-error=stringop-overflow -Wno-error=cpp -Wno-missing-field-initializers -Wno-unknown-warning-option' | |||
| CXX_FLAGS='-Wno-error=stringop-overflow -Wno-error=cpp -Wno-missing-field-initializers -Wno-unknown-warning-option -Wno-template-id-cdtor' | |||
There was a problem hiding this comment.
-Wno-template-id-cdtor seems to be gcc specific, not supported by clang.
clang-18 -Wno-template-id-cdtor a.cpp
warning: unknown warning option '-Wno-template-id-cdtor' [-Wunknown-warning-option]
There was a problem hiding this comment.
Sorry for confusion. Yes it is for GCC.
There was a problem hiding this comment.
What version of gcc? Could you post the relevant error? Thanks
There was a problem hiding this comment.
I see. Thanks. I am moving gluten build to a separate environment.
NN---
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Clang 18 fails building.
How was this patch tested?
Building using clang 18.