Skip to content

[VL] Enable base64 and unbase64 functions #9596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 9, 2025
Merged

[VL] Enable base64 and unbase64 functions #9596

merged 6 commits into from
Jul 9, 2025

Conversation

zhli1142015
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

Depends on facebookincubator/velox#13238 and facebookincubator/velox#13185

How was this patch tested?

UT

@github-actions github-actions bot added CORE works for Gluten Core BUILD VELOX labels May 12, 2025
@github-actions GitHub Actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zhli1142015 zhli1142015 changed the title Enable base64 unbase64 [VL] Enable base64 and unbase64 functions May 12, 2025
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@zhli1142015 zhli1142015 mentioned this pull request May 12, 2025
Closed
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@zhli1142015 zhli1142015 force-pushed the enable_base64_unbase64 branch from b13ed58 to bd2c6dc Compare May 12, 2025 14:54
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@zhli1142015 zhli1142015 force-pushed the enable_base64_unbase64 branch from d928b91 to 6cc29e2 Compare May 13, 2025 05:33
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@zhli1142015 zhli1142015 force-pushed the enable_base64_unbase64 branch from ae4a47f to 1e77f55 Compare May 13, 2025 08:41
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

rui-mo
rui-mo reviewed May 13, 2025
View reviewed changes
Copy link
Contributor

@rui-mo rui-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the relevant Gluten PR! Would you resolve the conflict and ensure the CI passes?

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@zhli1142015 zhli1142015 force-pushed the enable_base64_unbase64 branch from 1a836ef to 5ee090c Compare May 22, 2025 14:19
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2025

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Jul 7, 2025
@zhouyuan
Copy link
Contributor

zhouyuan commented Jul 8, 2025

@zhli1142015 Would you please do a rebase? It seems the two patch are landed Velox already

@zhouyuan zhouyuan removed the stale stale label Jul 8, 2025
@zhli1142015 zhli1142015 force-pushed the enable_base64_unbase64 branch from 5ee090c to a039c72 Compare July 9, 2025 02:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2025

Run Gluten Clickhouse CI on x86

@zhli1142015 zhli1142015 requested review from rui-mo and zhouyuan July 9, 2025 04:37
zhouyuan
zhouyuan approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot removed the BUILD label Jul 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2025

Run Gluten Clickhouse CI on x86

@zhouyuan zhouyuan merged commit a036066 into apache:main Jul 9, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouyuan zhouyuan zhouyuan approved these changes

@rui-mo rui-mo Awaiting requested review from rui-mo

Assignees
No one assigned
Labels
CORE works for Gluten Core VELOX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhli1142015 @zhouyuan @rui-mo