[Fix #3772] Duplicate function error #3774
Conversation
fjtirado
force-pushed
the
Fix_#3772
branch
3 times, most recently
from
3d9aca7
to
4e24016
Compare
| items.forEach(item -> { | ||
| V toAdd = converter.apply(item); | ||
| if (!helper.add(toAdd)) { | ||
| duplicates.compute(toAdd, (k, v) -> v == null ? 2 : ++v); |
There was a problem hiding this comment.
Although the helper set is not stricly needed, since you can remove not duplicates from the map after the main loop is completed
duplicates().values().removeIf ( v -> v == 1);
it will slighly affects the performace of the most common case. You have to remove original number - duplicate elements from the map. If duplicate elements is 0 (the most common case) you remove the original number.
It can be argued thad adding the helper Set consumes more memory, but this is not completely true, because at the end a HashSet is a "capped" HashMap. Since the number of Map key buckets depends on the number of duplicates, with a helper map you have original number + duplicate number buckets, without it you have original number buckets. So you only have the duplicate buckets as additional memory (precisely the addtional memory that will be preserved when the method returns) and as benefit you save the removal.
| { | ||
| "name": "pushData", | ||
| "type": "custom", | ||
| "operation": "script:python:print('javierito')" |
There was a problem hiding this comment.
Different operation but same name (which is the one to be checked) makes them duplicated, clear example!
Fix #3772