-
Notifications
You must be signed in to change notification settings - Fork 222
kie-tools-issues#3097: [SonataFlow] Dev UI does not render object input #3110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
kie-tools-issues#3097: [SonataFlow] Dev UI does not render object input #3110
Conversation
@ricardozanini @domhanak I see we are having this GH error on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a specialist on typescript, but this sounds good to me :)
@ljmotta Would be an SME here. Tagging him for awareness. |
@fantonangeli Are we creating a new convention here with the "customData": {
"type": "string",
"description": "Custom JSON data",
"uniforms": { "language": "json" }
} Or is this a convention that already exists? |
🆘 Help wanted 🆘 @tiagobento I used a convention already defined in Uniforms:
IMO Solution 5 is a kind of workaround, but it's the only working ATM. |
I'll just share my experience with users. If the data input schema attribute is a complex object without attributes, e.g., |
@fantonangeli Hi there. To make Uniforms stop complaning, you'll need to modify the validator, adding this new type. We have this on the |
@ljmotta Awesome, thank you so much. This means that solution 2 is feasible. Because the request for a Code Editor is not SonataFlow specific, I still think other packages can benefit from having this feature on @tiagobento @ljmotta @ricardozanini @fjtirado |
@fantonangeli I think the option 2 is better. This way we will have a specific field for a specific format. I don't like the idea of changing the generic |
Can't we have 5 only in sonataflow side? |
…97-SonataFlow-Dev-UI-does-not-render-object-input
packages/runtime-tools-swf-enveloped-components/src/uniforms/FormSwfAutoFieldValue.ts
Outdated
Show resolved
Hide resolved
…97-SonataFlow-Dev-UI-does-not-render-object-input
…97-SonataFlow-Dev-UI-does-not-render-object-input
|
||
## @kie-tools/sonataflow-uniforms | ||
|
||
This package provides additional uniforms-patternfly components for SonataFlow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: list the additional components we define and their purpose. Also a guide on how to use the component would be nice imho.
We could also include or reference some docs on how to add new or when to add new components for easier contributions and maintenance of this package.
Closes #3097
This PR reopens: #3100
This introduces a Code Editor which supports multiple languages and shows validation results.
In this initial version, only JSON is supported via the JSON Schema definition, but the underlying React component supports other languages and can be extended easily.
To use it, define a field like this in your JSON Schema:
Then the form will send
customData
as anobject
type to the endpoint.How to test on SonataFlow Deployment Webapp with a mocked backend:
kie-tools/packages/sonataflow-deployment-webapp
pnpm start
service
workflowHow to test on SonataFlow Deployment Webapp with a real backend:
mvn quarkus:dev
kie-tools/packages/sonataflow-deployment-webapp
pnpm start:dev-webapp
hello
workflowPreview:
https://github.com/user-attachments/assets/e7e3491a-d6c7-4b70-bada-974b9e9de246