kie-issues#1155: Add end-to-end tests for keyboard shortcuts for the new DMN Editor #3128
Conversation
yesamer
changed the title
There was a problem hiding this comment.
Thank you for the PR @ramkumar-hub . I put some comments inline regarding tests. Furthermore I am not sure about the strategy we chose for:
- copying the existing
__fixtures__like creating a copy ofnodes.ts - using same port as in
dmn-editorso indmn-editor-envelope-9901
packages/chrome-extension-pack-kogito-kie-editors/e2e-tests/tests/BpmnFullScreenTest.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Do we test node deletion or node name deletion?
There was a problem hiding this comment.
Also here, same question, do we test node deletion or node name deletion?
There was a problem hiding this comment.
the screenshot name seems to be different than the screenshot content, is it expected?
- name says
all - while content has single node selected
There was a problem hiding this comment.
I think I do not see properties in the screenshot content, could you please clarify if the screenshot is correct?
There was a problem hiding this comment.
could you please clarify if the screenshot is correct?
There was a problem hiding this comment.
This test is to toggle between select and deselect all nodes using shortcut key- A
Select all nodes using shortcut - A
Deselect all nodes using shortcut - A
There was a problem hiding this comment.
comparing other screenshots, it sounds zoom level is same, could you please clarify?
There was a problem hiding this comment.
cold you please clarify if the screenshot is correct? it seems like 100% zoom level
packages/chrome-extension-test-helper/src/framework/github-editor/GitHubEditorPage.ts
Outdated
Show resolved
Hide resolved
ramkumar-hub
force-pushed
the
kie-issues#1155-e2e-test-keyboard-shortcuts
branch
from
93d72ee to
a8e5600
Compare
Closes apache/incubator-kie-issues#1155
Setup Storybook
Added DevWebapp Story
Added Loan Pre Qualification Story
Setup Playwright
Added required fixtures for the End-To-End tests
Added End-To-End tests for the keyboard shortcuts
Setup containerization for the End-To-End tests