kie-issues#1958: Add End-To-End tests for Data Type tab for the new DMN Editor #3129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesamer
changed the title
ljmotta
changed the title
ljmotta
requested changes
May 13, 2025
There was a problem hiding this comment.
@ramkumar-hub Thanks a lot for this PR, it is looking pretty good. Great work with the new fixtures, test structure and names.
I have just a few points to add, but the tests are looking great.
packages/dmn-editor/tests-e2e/drgDataTypes/deleteDataType.spec.ts
Outdated
Show resolved
Hide resolved
packages/dmn-editor/tests-e2e/drgDataTypes/createDataTypeWithoutConstraint.spec.ts
Outdated
Show resolved
Hide resolved
packages/dmn-editor/tests-e2e/drgDataTypes/createDataTypeWithConstraint.spec.ts
Outdated
Show resolved
Hide resolved
packages/dmn-editor/tests-e2e/drgDataTypes/copyPasteDataType.spec.ts
Outdated
Show resolved
Hide resolved
packages/dmn-editor/tests-e2e/drgDataTypes/copyPasteDataType.spec.ts
Outdated
Show resolved
Hide resolved
packages/dmn-editor/tests-e2e/drgDataTypes/copyPasteDataType.spec.ts
Outdated
Show resolved
Hide resolved
packages/dmn-editor/tests-e2e/drgDataTypes/copyPasteDataType.spec.ts
Outdated
Show resolved
Hide resolved
Open
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to apache/incubator-kie-issues#1958
Created End-To-End Test below-mentioned scenario for Data Type tab
Create Data type with all possible built-in type
Is collection - false
Is struct - false
Without constraint
Create Data type with all possible built-in types (Except DateTime / DateTimeDuration / Time / YearsMonthsDuration)
With constraints
Expression
Enumeration
Range
Create Data type with all possible built-in types
Struct with property
Copy/Paste Data types with Empty Data Types
Copy/Paste Data types with Existing Data Types
Delete Data types
Added End-To-End tests for below data type with constraints:
Date
Date Time
Date Time Duration
Time
Years Months Duration
Added End-To-End test for struct Data type property actions:
Cut
Copy
Paste - (Copy struct date type and paste as new data type)
Paste Property
Extract Data Type
Remove
Updated Data type fixtures to create constraints (Date, Date Time, Date Time Duration, Time, Years Months Duration)
Refactored existing names in the dataType fixtures