kie-issues#898: DMN Editor: Moving the divider line of or resizing a Decision Service #3162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagobento
requested changes
May 30, 2025
There was a problem hiding this comment.
Thank you @aswathitv! Another great PR. Left some comments inline, please consider them.
tiagobento
requested changes
Jun 26, 2025
packages/dmn-editor/src/mutations/updateDecisionServiceDividerLine.ts
Outdated
Show resolved
Hide resolved
|
@aswathitv Wouldn't it be better to include all the code responsible for special treatment when resizing a node inside the |
jomarko
reviewed
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes kie#898
Resizing a Decision Service in a DRD resizes decision service in all other DRDs that contain it.
Moving the divider line of a decision service in a DRD replicates the change in all other DRD that contains the decision service.
Resizing a decision service in a DRD results in repositioning of neighbouring nodes in other DRD so as to avoid overlapping.