Skip to content

kie-issues#890: DMN Editor: Adding a Decision to a Decision Service #3188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

kie-issues#890: DMN Editor: Adding a Decision to a Decision Service #3188

wants to merge 3 commits into from
+152 −6

Conversation

aswathitv
Copy link
Contributor

Closes kie#890

  • Adding a node to a decision service in a DRD adds the node in the decision services if expanded in all DRDs.

  • Moving a node to a decision service in a DRD moves the node to the decision service if expanded in all DRDs.

  • Moving a node to a decision service in a DRD removes the node if decision service is collapsed in other DRDs.

@aswathitv aswathitv requested a review from tiagobento as a code owner June 25, 2025 11:03
@tiagobento tiagobento changed the title kie-issues#890: DMN Editor:Adding a Decision to a Decision Service kie-issues#890: DMN Editor: Adding a Decision to a Decision Service Jun 26, 2025
@tiagobento
Copy link
Contributor

Why not put the code inside addDecisionToDecisionService? Also I guess we could use some comments in the complicated parts? :)

@tiagobento
Copy link
Contributor

tiagobento commented Jul 10, 2025 •
edited
Loading

@aswathitv PR checks are red. Do you mind checking? Thanks!

EDIT: I re-triggered them just in case, as they all failed on bootstrap, so might be an intermittent network error.

jomarko
jomarko reviewed Jul 15, 2025
View reviewed changes
Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe screenshots needs to be updated to 1.6 dmn model version

@aswathitv
Copy link
Contributor Author

@jomarko This PR doesn't have dmn 1.6 related changes

@jomarko
Copy link
Contributor

jomarko commented Jul 16, 2025

@aswathitv my understanding of #3198 was, that the latest version of tooling already has DMN 1.6 support.

Anyway, my point is, if #3188 is merged before #3198, then #3198 needs more updates on screenshot, or #3188 needs to be merged after #3198, then we need to update screenshots as part of #3188.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jomarko jomarko jomarko left review comments

@tiagobento tiagobento tiagobento approved these changes

Assignees
No one assigned
Labels
area:dmn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decision Services & multiple DRDs: Adding a Decision to a Decision Service.
3 participants
@aswathitv @tiagobento @jomarko