Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize : compatible for client_protocol_version > server_protocol_version #7250

Merged
merged 7 commits into from
Apr 2, 2025

Conversation

Bughue
Copy link
Contributor

@Bughue Bughue commented Mar 25, 2025

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #7251

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@Bughue Bughue requested review from slievrly and funky-eyes March 25, 2025 06:32
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 54.23%. Comparing base (6083fa1) to head (ca36b3d).

Files with missing lines Patch % Lines
...che/seata/core/rpc/netty/MultiProtocolDecoder.java 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7250      +/-   ##
============================================
- Coverage     54.23%   54.23%   -0.01%     
  Complexity     7267     7267              
============================================
  Files          1178     1178              
  Lines         41952    41958       +6     
  Branches       4923     4925       +2     
============================================
+ Hits          22753    22755       +2     
- Misses        17048    17052       +4     
  Partials       2151     2151              
Files with missing lines Coverage Δ
...che/seata/core/rpc/netty/MultiProtocolDecoder.java 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@slievrly slievrly added this to the 2.4.0 milestone Apr 2, 2025
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 108240f into apache:2.x Apr 2, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compatible for client_protocol_version > server_protocol_version
2 participants