Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table Model Subquery] Support uncorrelated quantified comparison #14534

Merged
merged 38 commits into from
Jan 20, 2025

Conversation

lancelly
Copy link
Contributor

No description provided.

@MiniSho
Copy link
Contributor

MiniSho commented Dec 24, 2024

⡇⢠⣌⡛⢿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿
⣇⢸⣿⣿⣦⣍⠻⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿
⣿⢸⣿⠿⣛⡵⣣⣌⠻⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿
⣿⡄⣒⣻⣽⣾⣿⣿⣷⣌⠻⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿
⣿⣇⢸⣿⣿⣿⣿⣿⣿⣿⣷⡌⢿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿
⣿⣿⡄⣿⣿⣿⣿⣿⣿⣿⣿⣿⣦⠙⢛⣛⣛⣉⠙⢿⣿⣿⣿⣿
⣿⣿⣷⠸⣿⣿⣿⣿⣿⣿⢿⣿⣿⣷⡐⢶⣶⣿⣿⡌⢻⣿⣿⣿
⣿⣿⣿⣇⢹⣿⣿⣿⣏⠰⡆⢻⣿⣿⣿⡌⢿⣿⣿⣿⣆⠻⣿⣿
⣿⣿⣿⠟⡀⢻⣿⣿⣿⣆⠰⣆⠻⢟⣱⣾⠄⠛⠛⠿⠿⢧⡙⣿
⣿⡿⢋⢜⣼⡄⢿⣿⣿⠿⣃⠹⣆⠹⠟⣡⣴⣌⠻⣿⣿⣶⣶⣾
⣿⣿⡄⢿⣿⣿⡄⢶⣾⣿⠿⠇⠘⣧⠸⠟⡫⢀⣤⣿⣿⣿⣿⣿
⣿⣿⣿⡌⢿⣿⣿⢀⠡⣴⣾⠿⢓⠘⢧⠀⡴⢿⣦⣝⢿⣿⣿⣿
⣿⣿⣿⣿⡌⢿⠇⣼⣆⠉⣂⣩⡴⣶⣴⣾⣿⡷⠎⣿⣆⢻⣿⣿
⣿⣿⣿⣿⣿⡌⢠⣿⣿⣿⣿⢸⡷⣿⡿⢿⣯⢡⣼⣿⣿⠈⣿⣿
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⡘⣧⡋⣾⣮⡛⣸⣿⡏⣍⢀⣿⣿
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣷⡘⠿⢡⣬⣙⢻⣿⠇⣿⣿⣿⣿
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣶⣿⣿⣿⡆⠋⣼⣿⣿⣿⣿
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣷⣾⣿⣿⣿⣿⣿
YOU MAKE QUERY GREAT AGAIN 🚀

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 63 lines in your changes missing coverage. Please review.

Project coverage is 39.28%. Comparing base (141b7ba) to head (55123de).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...ce/relational/aggregation/CountAllAccumulator.java 0.00% 28 Missing ⚠️
...formQuantifiedComparisonApplyToCorrelatedJoin.java 80.16% 24 Missing ⚠️
...nner/optimizations/PushPredicateIntoTableScan.java 60.00% 6 Missing ⚠️
...execution/relational/ColumnTransformerBuilder.java 0.00% 3 Missing ⚠️
...rce/relational/aggregation/AccumulatorFactory.java 0.00% 1 Missing ⚠️
...ne/plan/relational/planner/SimplePlanRewriter.java 94.11% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14534      +/-   ##
============================================
+ Coverage     39.12%   39.28%   +0.15%     
  Complexity      193      193              
============================================
  Files          4417     4420       +3     
  Lines        281258   281446     +188     
  Branches      34780    34800      +20     
============================================
+ Hits         110040   110563     +523     
+ Misses       171218   170883     -335     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackieTien97 JackieTien97 merged commit fea2e4f into master Jan 20, 2025
46 of 47 checks passed
@JackieTien97 JackieTien97 deleted the support_uncorrelated_quantified_comparison branch January 20, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants