Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe: implement external sources strategy and MQTT extractor #15275

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

XNX02
Copy link
Contributor

@XNX02 XNX02 commented Apr 4, 2025

No description provided.

@SteveYurongSu SteveYurongSu requested a review from Copilot April 7, 2025 02:13
@SteveYurongSu SteveYurongSu self-assigned this Apr 7, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/mqtt/MQTTPublishHandler.java:185

  • Method name 'ExtractTable' should use lowerCamelCase to follow Java naming conventions. Consider renaming it to 'extractTable'.
private void ExtractTable(TableMessage message, MqttClientSession session) {

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/mqtt/MQTTPublishHandler.java:276

  • Method name 'ExtractTree' should use lowerCamelCase to maintain consistency with Java naming conventions. Consider renaming it to 'extractTree'.
private void ExtractTree(TreeMessage message, MqttClientSession session) {

@SteveYurongSu SteveYurongSu requested a review from Copilot April 7, 2025 08:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

@SteveYurongSu
Copy link
Member

@luoluoyuyu PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants