JAMES-4137 Upgrade S3 SDK to 2.30.x onwards #2739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests with Scality and MinIO passed (failed without this backward option). I would love to double check this against OVH S3. Maybe we can put this PR on hold for a while, so the community can review and try against their S3 storage solution, if needed. |
chibenwa
approved these changes
Jun 10, 2025
Arsnael
reviewed
Jun 11, 2025
Arsnael
approved these changes
Jun 11, 2025
Yes, it has been introduced recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In S3 SDK version 2.30.0, AWS team introduced a breaking change in the integrity check in the driver:
cf: aws/aws-sdk-java-v2#5802
This breaks the compatibility with 3rd party object storage(s) that still rely on MD5 checksum. We failed to upgrade the SDK in the past: #2638.
It seems after receiving a lot of complaints from the community (Apache Hadoop, Apache Iceberg, Apache Spark...), AWS has agreed to have an option to maintain backward compatibility with S3-compatible storages. cf aws/aws-sdk-java-v2#6055.
Apache Iceberg is starting to adopt the backward compatibility option: apache/iceberg#12264.
Let's try to adopt this on our side, with care.