Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump codemirror from 5.65.16 to 6.0.1 in /jena-fuseki2/jena-fuseki-ui #2789

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 23, 2024

Bumps codemirror from 5.65.16 to 6.0.1.

Changelog

Sourced from codemirror's changelog.

6.0.1 (2022-06-30)

Bug fixes

Work around limitations in tree-shaking software that prevented basicSetup from being removed when unused.

6.0.0 (2022-06-08)

Breaking changes

Change the package name from @codemirror/example-setup to just codemirror.

The package no longer exports EditorState (since that is no longer necessary to set up a basic editor).

New features

The new minimalSetup export provides a minimal set of editor extensions.

0.20.0 (2022-04-20)

Breaking changes

Update dependencies to 0.20.0

0.19.3 (2022-03-30)

New features

Add the extension that shows a crosshair cursor when Alt is held down to the basic setup.

0.19.1 (2021-12-13)

New features

The basic setup now includes the dropCursor extension.

0.19.0 (2021-08-11)

Breaking changes

Update dependencies to 0.19.0

0.18.2 (2021-05-25)

Bug fixes

Fix too-low dependency on @​codemirror/gutter that could cause broken upgrades.

0.18.1 (2021-05-15)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [codemirror](https://github.com/codemirror/basic-setup) from 5.65.16 to 6.0.1.
- [Changelog](https://github.com/codemirror/basic-setup/blob/main/CHANGELOG.md)
- [Commits](https://github.com/codemirror/basic-setup/commits/6.0.1)

---
updated-dependencies:
- dependency-name: codemirror
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 23, 2024
@afs
Copy link
Member

afs commented Oct 23, 2024

This PR fails with:

[INFO] --- frontend:1.15.1:yarn (yarn run build) @ jena-fuseki-ui ---
[INFO] Running 'yarn run build' in /home/afs/ASF/jena-review/jena-fuseki2/jena-fuseki-ui
[INFO] yarn run v1.22.17
[INFO] $ vite build
[INFO] vite v5.4.9 building for production...
[INFO] transforming...
[INFO] ✓ 26 modules transformed.
[INFO] x Build failed in 214ms
[INFO] error during build:
[INFO] [commonjs--resolver] Missing "./mode/turtle/turtle" specifier in "codemirror" package
[INFO]     at e (file:///home/afs/ASF/jena-review/jena-fuseki2/jena-fuseki-ui/node_modules/vite/dist/node/chunks/dep-Cyk9bIUq.js:46030:25)
[INFO]     at n (file:///home/afs/ASF/jena-review/jena-fuseki2/jena-fuseki-ui/node_modules/vite/dist/node/chunks/dep-Cyk9bIUq.js:46030:627)
[INFO]     at o (file:///home/afs/ASF/jena-review/jena-fuseki2/jena-fuseki-ui/node_modules/vite/dist/node/chunks/dep-Cyk9bIUq.js:46030:1297)
[INFO]     at resolveExportsOrImports (file:///home/afs/ASF/jena-review/jena-fuseki2/jena-fuseki-ui/node_modules/vite/dist/node/chunks/dep-Cyk9bIUq.js:46651:18)
[INFO]     at resolveDeepImport (file:///home/afs/ASF/jena-review/jena-fuseki2/jena-fuseki-ui/node_modules/vite/dist/node/chunks/dep-Cyk9bIUq.js:46674:25)
[INFO]     at tryNodeResolve (file:///home/afs/ASF/jena-review/jena-fuseki2/jena-fuseki-ui/node_modules/vite/dist/node/chunks/dep-Cyk9bIUq.js:46439:16)
[INFO]     at Object.resolveId (file:///home/afs/ASF/jena-review/jena-fuseki2/jena-fuseki-ui/node_modules/vite/dist/node/chunks/dep-Cyk9bIUq.js:46189:19)
[INFO]     at file:///home/afs/ASF/jena-review/jena-fuseki2/jena-fuseki-ui/node_modules/rollup/dist/es/shared/node-entry.js:19936:40
[INFO]     at async PluginDriver.hookFirstAndGetPlugin (file:///home/afs/ASF/jena-review/jena-fuseki2/jena-fuseki-ui/node_modules/rollup/dist/es/shared/node-entry.js:19836:28)
[INFO]     at async resolveId (file:///home/afs/ASF/jena-review/jena-fuseki2/jena-fuseki-ui/node_modules/rollup/dist/es/shared/node-entry.js:18527:26)
[INFO] error Command failed with exit code 1.
[INFO] error Command failed with exit code 1.info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@kinow kinow self-assigned this Oct 23, 2024
@kinow kinow marked this pull request as draft October 23, 2024 13:30
@kinow
Copy link
Member

kinow commented Oct 23, 2024

Thanks Andy. Looks like there are a few breaking changes. Had a look at their migration docs, but unfortunately it seems like the Edit view is still broken after this update - https://codemirror.net/docs/migration/

I must be missing something simple when initializing CodeMirror… will try it again another day with more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants