Merged
Conversation
afs
force-pushed
the
gh3755-queryiterators
branch
from
84f09d1 to
062013a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #3755
cancel()contract - the work to stop an iterator happens on the query execution thread.QueryIteratorBase.requestCancel()optional. Mostly, using the usual framework will work.There is no change to passing down cancellations although this might be desirable to ensure consistent behaviour long term.
A few QueryIterators do not use
QueryIteratorBase:Test use only -
TestQueryIterSortQueryIteratorCallbackService enhancer:
QueryIterSlottedBaseQueryIterServiceBulkQueryIterWrapperCacheRequestExecutorBy submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.