-
Notifications
You must be signed in to change notification settings - Fork 540
feat(tdigest): add TDIGEST.MERGE
command implementation
#3054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tdigest): add TDIGEST.MERGE
command implementation
#3054
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Implements the TDIGEST.MERGE
command end-to-end and adds corresponding tests.
- Adds
TDigestMerge
overloads in the core and hooks them into the Redis command layer. - Defines parsing, validation, and execution logic for
TDIGEST.MERGE
in the server. - Introduces Go unit tests to cover argument errors and successful merge scenarios.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
tests/gocase/unit/type/tdigest/tdigest_test.go | New Go tests for TDIGEST.MERGE argument handling and merge logic |
src/types/tdigest.h | Declares new TDigestMerge overloads with delta parameter |
src/types/tdigest.cc | Implements TDigestMerge functions and removes unused include |
src/types/redis_tdigest.h | Adds Merge method and TDigestMergeOptions struct |
src/types/redis_tdigest.cc | Implements the TDigest::Merge method |
src/commands/error_constants.h | Adds error constants for parsing numkeys and wrong keywords |
src/commands/cmd_tdigest.cc | Adds CommandTDigestMerge parser/executor and registers the command |
( I'm currently focus on other things, I might have time on Friday or later, you can merge this firstly. I would post-review this weekend) |
|
Issue
#2805
Proposed Changes
TDIGEST.MERGE
command implementation