Remove direct usage of sun.misc.Signal#7144
Closed
pan3793 wants to merge 6 commits intoapache:masterfrom
Closed
Conversation
Member
Author
LuciferYang
approved these changes
Jul 21, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7144 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 701 701
Lines 43501 43508 +7
Branches 5895 5897 +2
======================================
- Misses 43501 43508 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Thanks, merged to master |
pan3793
added a commit
that referenced
this pull request
Dec 26, 2025
### Why are the changes needed?
I hit an issue while preparing 1.11.0 RC0, which indicates I need to use a higher version of JDK for releasing.
```
[INFO] --- antlr4:4.13.1:antlr4 (default) kyuubi-extension-spark-4-0_2.13 ---
[WARNING] Error injecting: org.antlr.mojo.antlr4.Antlr4Mojo
java.lang.UnsupportedClassVersionError: org/antlr/v4/Tool has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0
at java.lang.ClassLoader.defineClass1 (Native Method)
at java.lang.ClassLoader.defineClass (ClassLoader.java:756)
at java.security.SecureClassLoader.defineClass (SecureClassLoader.java:142)
```
In #7144, we made it always use `-release:8` for `jdk9+`, so we still produce Java 8 compatible bytecode even using JDK 17, for all modules except Spark 4.0/4.1 extension modules.
### How was this patch tested?
Will verify this in the next RC of 1.11.0
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #7289 from pan3793/release-java17.
Closes #7289
17e29be [Cheng Pan] Release requires Java 17 or 21
Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
pan3793
added a commit
that referenced
this pull request
Dec 26, 2025
### Why are the changes needed?
I hit an issue while preparing 1.11.0 RC0, which indicates I need to use a higher version of JDK for releasing.
```
[INFO] --- antlr4:4.13.1:antlr4 (default) kyuubi-extension-spark-4-0_2.13 ---
[WARNING] Error injecting: org.antlr.mojo.antlr4.Antlr4Mojo
java.lang.UnsupportedClassVersionError: org/antlr/v4/Tool has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0
at java.lang.ClassLoader.defineClass1 (Native Method)
at java.lang.ClassLoader.defineClass (ClassLoader.java:756)
at java.security.SecureClassLoader.defineClass (SecureClassLoader.java:142)
```
In #7144, we made it always use `-release:8` for `jdk9+`, so we still produce Java 8 compatible bytecode even using JDK 17, for all modules except Spark 4.0/4.1 extension modules.
### How was this patch tested?
Will verify this in the next RC of 1.11.0
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #7289 from pan3793/release-java17.
Closes #7289
17e29be [Cheng Pan] Release requires Java 17 or 21
Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit eecdaaa)
Signed-off-by: Cheng Pan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This PR replaces the
sun.misc.Signalwith the Kyuubi wrapped one, see apache/kyuubi-shaded#64, which allows Kyuubi to use any of Java 8+ to compile with-release:8while still ensuring compatibility with Java 8.How was this patch tested?
Pass GHA.
Local tested by building against JDK 21, running on JDK 8, everything works as expected.
Was this patch authored or co-authored using generative AI tooling?
No.