-
Notifications
You must be signed in to change notification settings - Fork 950
Remove direct usage of sun.misc.Signal
#7144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7144 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 701 701
Lines 43501 43501
Branches 5895 5895
======================================
Misses 43501 43501 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Why are the changes needed?
This PR replaces the
sun.misc.Signal
with the Kyuubi wrapped one, see apache/kyuubi-shaded#64, which allows Kyuubi to use any of Java 8+ to compile with-release:8
while still ensuring compatibility with Java 8.How was this patch tested?
Pass GHA.
Local tested by building against JDK 21, running on JDK 8, everything works as expected.
Was this patch authored or co-authored using generative AI tooling?
No.