Simplify use of log4cxx-qt in consuming CMake projects#600
Open
Simplify use of log4cxx-qt in consuming CMake projects#600
Conversation
Contributor
|
thanks for looking into this, I was going to look at it this weekend. It looks like it's failing due to missing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add support for
find_package(log4cxx COMPONENTS qt)in consuming CMake projects.Support for
find_package(log4cxx-qt)will cease when the major version of Log4cxx changes to 2.The generated cmake scripts are now tested in CI