Tessellator: Improve logic when two holes share the same vertex with the polygon #13980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigtaverner
suggested changes
Nov 7, 2024
lucene/core/src/test/org/apache/lucene/geo/TestTessellator.java
Outdated
Show resolved
Hide resolved
iverase
added a commit
that referenced
this pull request
Nov 11, 2024
…the polygon (#13980) This commit tries to improve the algorithm by: 1.- If there is only one vertex, then there is not further checks and that's the one used. 2.- if there is a common vertex, it first compute the signed area of the join, if they have different sign, it chooses the negative one as that's the convex union. If they have the same sign, it computes the angle of the join and chooses the smallest angle.
iverase
added a commit
that referenced
this pull request
Nov 11, 2024
…the polygon (#13980) This commit tries to improve the algorithm by: 1.- If there is only one vertex, then there is not further checks and that's the one used. 2.- if there is a common vertex, it first compute the signed area of the join, if they have different sign, it chooses the negative one as that's the convex union. If they have the same sign, it computes the angle of the join and chooses the smallest angle. # Conflicts: # lucene/CHANGES.txt # lucene/core/src/test/org/apache/lucene/geo/TestTessellator.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the situation with David Eberly's algorithm for finding a bridge between a hole and outer polygon was failing was the case of a polygon sharing a vertex with the outer polygon. To fixed that we added a step to find shared vertex between the hole and the polygon.
That worked well except on the situations where more than one hole was sharing the same vertex with the outer polygon. In those cases, we might have more than one vertex to choose from and we need to make sure we pick the right one. The current algorithm test if the line joining the previous vertex if the outer polygon band the next vertex from the hole intersects the polygon. This worked well in many cases but it is not generic as it depends on the topology of the union.
This commit tries to improve the algorithm by:
I added a few test to check the different combinations and the new algorithm seems resilient to them.
In addition I clean the tessellator class by removing some useless final declarations for static methods and clean up the visibility of some internal classes (no point of protected inner classes on a final class) and remove unused methods. I clean up the tests too.
fixes #13841