Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message for unit test failures for lucene.testsettings.json, #999 #1021

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

paulirwin
Copy link
Contributor

@paulirwin paulirwin commented Nov 13, 2024

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Improves the failed unit test message to provide an example lucene.testsettings.json.

Fixes #999

Description

The lucene.testsettings.json seems to work more reliably and is a little more user-friendly than the runsettings file, so this improves the failed unit test message to provide a generated lucene.testsettings.json file. This also uses C# 11 multi-line strings instead of manual string concatenation.

@paulirwin paulirwin merged commit b28fa34 into apache:master Nov 13, 2024
197 checks passed
@paulirwin paulirwin deleted the issue/999 branch November 13, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change failed test message to use lucene.testsettings.json instead of .runsettings
2 participants